Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Token attributes #264

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Improved Token attributes #264

merged 3 commits into from
Mar 8, 2024

Conversation

steven2308
Copy link
Collaborator

@steven2308 steven2308 commented Mar 8, 2024

Description

Describe the additions/improvements this PR contains.

Checklist

  • Verified code additions
  • Updated NatSpec comments (if applicable)
  • Regenerated docs
  • Ran prettier
  • Added tests to fully cover the changes

PR-Codex overview

This PR updates the IERC7508 contract with new functions for managing attributes metadata URI and setting attributes for tokens.

Detailed summary

  • Added getAttributesMetadataURI and setAttributesMetadataURI functions
  • Updated parameter types in setStringAttributes, setUintAttributes, setBoolAttributes, setAddressAttributes, setBytesAttributes functions
  • Modified return types in getAttributes and getStringAttributes functions
  • Improved readability and consistency in function signatures

The following files were skipped due to too many changes: contracts/RMRK/extension/tokenAttributes/IERC7508.sol, docs/RMRK/extension/tokenAttributes/IERC7508.md, docs/RMRK/extension/tokenAttributes/RMRKTokenAttributesRepository.md, contracts/RMRK/extension/tokenAttributes/RMRKTokenAttributesRepository.sol, test/extensions/tokenAttributesRepository.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

No long uses structs as return values for batch getters.
If a single attribute is sent on batch getter/setters it will use it for all collections and tokens.
@steven2308 steven2308 merged commit 7c9d05d into dev Mar 8, 2024
4 checks passed
Copy link

Improved Token attributes

Generated at commit: 97aedc7adb089ec824804c899160ef29faa0561d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
0
0
4
25
31
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant